[SYCL] Change UConvert arg type to unsigned and SConvert arg type to signed #19316
+235
−1,441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signed To align with SPIR-V spec and SPV-IR in SPIRV-LLVM-Translator.
bader
reviewed
Jul 7, 2025
| @@ -9,6 +9,12 @@ | |||
|
|
|||
| // Autogenerated by gen-libclc-test.py | |||
|
|
|||
| // INTEL_CUSTOMIZATION | |||
There was a problem hiding this comment.
@wenju-he, please, remove INTEL_CUSTOMIZATION comments.
frasercrmck
approved these changes
Jul 7, 2025
Fznamznon
reviewed
Jul 7, 2025
| @@ -803,7 +803,7 @@ foreach rnd = ["", "_rte", "_rtn", "_rtp", "_rtz"] in { | |||
| } | |||
|
|
|||
| foreach sat = ["", "_sat"] in { | |||
| foreach InType = TLAllInts.List in { | |||
| foreach InType = TLUnsignedInts.List in { | |||
There was a problem hiding this comment.
Could you please add a clang test for the change?
There was a problem hiding this comment.
Could you please add a clang test for the change?
done in 587306a
Fznamznon
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align with SPIR-V spec and SPV-IR in SPIRV-LLVM-Translator.